Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(snowflake): patch oscrypto in the nix environment #6955

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 29, 2023

This PR adds two tiny, related patches to oscrypto in the nix environment.

I discovered this problem by trying to run snowflake tests after a recent
nixpkgs update (ca2b023).

This update broke snowflake tests in the nix environment, due to a switch to
openssl 3 in that update.

Searching around the internets I found
dbt-labs/dbt-core#3366, which led me to
wbond/oscrypto#78 which is fixed upstream in
oscrypto.

Nix has a solid patching mechanism for doing post-install surgery on packages,
which I use here to apply two patches that address the regex-version-searching
bug (the root cause of the original failure).

We can remove these when the next version of oscrypto is released to PyPI.

@cpcloud cpcloud added this to the 7.0 milestone Aug 29, 2023
@cpcloud cpcloud added dependencies Issues or PRs related to dependencies snowflake The Snowflake backend nix Issues or PRs related to nix labels Aug 29, 2023
@jcrist jcrist merged commit f9f54e5 into ibis-project:master Aug 29, 2023
@cpcloud cpcloud deleted the patch-oscrypto branch August 29, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies nix Issues or PRs related to nix snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants